Auto-scale Y-axis for indicators when zooming #356 #389
+32
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benouare
approved these changes
Jun 18, 2021
zlpatel
commented
Jun 21, 2021
| @@ -607,9 +615,16 @@ def __eq__(self, other): | |||
|
|
|||
| custom_js_args = dict(ohlc_range=fig_ohlc.y_range, | |||
| source=source) | |||
| if plot_pl: | |||
| custom_js_args.update(pl_range=fig_pl.y_range) | |||
There was a problem hiding this comment.
This change was not required. I think I might have added that while I was trying to see if I can add auto scale feature for P/L chart. Since it's already been added in the commit, I still see a value in keeping it for future use, But if you think that it's not worth adding it right now and will cause confusion then I can remove it. Let me know.
kernc
force-pushed
the
master
branch
3 times, most recently
from
7fd493d to
e7981c7
Compare
kernc
force-pushed
the
master
branch
9 times, most recently
from
60eff81 to
109c352
Compare
|
@kernc can you please take a look at this pull request? |
kernc
force-pushed
the
master
branch
5 times, most recently
from
428c361 to
0ce6cab
Compare
kernc
force-pushed
the
master
branch
3 times, most recently
from
70abc06 to
c79ffb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356